Open
Conversation
So this change makes the whitelist check a positive instead of a negative. Basic logic here: if the REMOTE_ADD or the X-Forwarded-For address match the whitelist, then continue with the content checking Rewrite rules to match the content of the c2 URIs. If both checks fail then it 404s the request.
benpturner
force-pushed
the
master
branch
4 times, most recently
from
c506ff9 to
b85516f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this change makes the whitelist check a positive instead of a negative. Basic logic here: if the REMOTE_ADD or the X-Forwarded-For address match the whitelist, then continue with the content checking Rewrite rules to match the content of the c2 URIs. If both checks fail then it 404s the request.
I'm also going to add the whitelist for the content list as well to make it easy to switch out the list of URIs, and probably make it easy to proxy multiple engagements at the same time.